Disable reqwest default features to not depend on openssl #2421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtyler
approved these changes
Aug 25, 2025
|
sorry but it needs to be rebased |
@sylvestre done |
|
fails with: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2421 +/- ##
==========================================
- Coverage 71.22% 67.97% -3.25%
==========================================
Files 64 64
Lines 35214 34723 -491
==========================================
- Hits 25080 23602 -1478
- Misses 10134 11121 +987 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@sylvestre I think I have everything downgraded that is incompatible with 1.75 |
|
Turns out updating with an older version requirement is just too hard, especially when I can't test out the windows stuff, so I'm downgrading this to just the one change to remove the default dependencies for reqwest. |
|
@sylvestre I just updated this again. Maybe the tests will pass this time after all the other crate updates. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #841
I also did a cargo update to get the latest dependencies. All the tests were able to build, and I did get a failure locally, but probably due to my setup.